feat(tracing): add generated metadata spans - #3269
Draft
james-elicx wants to merge 1 commit into
Draft
james-elicx wants to merge 1 commit into
james-elicx wants to merge 1 commit into
Conversation
james-elicx
added this pull request to stack #3258
September 15, 2026 02:43
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
james-elicx
force-pushed
the
codex/otel-05c-metadata-spans
branch
from
September 15, 2026 02:45
f9b0651 to
098e10a
Compare
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
james-elicx
removed this pull request from stack #3258
September 15, 2026 06:40
james-elicx
added this pull request to stack #3285
September 15, 2026 06:40
james-elicx
removed this pull request from stack #3285
September 15, 2026 06:59
james-elicx
added this pull request to stack #3287
September 15, 2026 06:59
james-elicx
removed this pull request from stack #3287
September 15, 2026 13:50
james-elicx
added this pull request to stack #3298
September 15, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResolveMetadata.generateMetadataspans through the shared framework tracerAppRender.getBodyResultso generated metadata and application child spans have the same parent as Next.js@sentry/nextjsintegration on WorkerdNext.js parity
Pinned against
vercel/next.js@b421cadefd31c1b59d117842021ded7c1ebaf5b4, especially:packages/next/src/lib/metadata/metadata-resolution-primitives.tspackages/next/src/lib/metadata/resolve-metadata.tspackages/next/src/server/app-render/app-render.tsxtest/e2e/opentelemetry/instrumentation/opentelemetry.test.tsThe trace route excludes parallel-slot directory keys, retains route groups/interception segments, and uses
not-found,forbidden, orunauthorizedplus the owning module route. Static metadata exports remain untraced.No OpenTelemetry package is added as a required vinext dependency, and no Sentry-specific runtime path is introduced. The same descriptors flow to Workers tracing automatically.
Validation
vp checkvp run vinext#buildPLAYWRIGHT_PROJECT=cloudflare-sentry-app pnpm run test:e2e(17 passed)@slotidentity findingsStack parent: #3268